Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to backup dependant resources(configmap,secret) along with pod,statefulset,daemonset,deployments #136

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

vineela1999
Copy link
Contributor

Signed-off-by: vineela1999 vineelapachipulusu@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation

kind enhancement

What this PR does / why we need it:
This PR implements the code which makes it possible to backup configmap or secret resource which is associated with pod,deployment,statefulset,daemonset when trying to backup these resources
We can use configmap or secret inside the pod,deployment,statefulset,daemonset yamls by specifying them inside init containers,containers,ephemeral containers through env or envFrom
Here we ensured its backing up successfully either ways
Which issue(s) this PR fixes:

Fixes #135
Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

kind TESTED

/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

controllers/backup/dependencyresolver.go Outdated Show resolved Hide resolved
controllers/backup/resourcecollector.go Show resolved Hide resolved
@AmitRoushan
Copy link
Collaborator

@vineela1999 Please add e2e testcase for the issue

@sushanthakumar sushanthakumar changed the base branch from development to main January 11, 2023 13:17
@vineela1999 vineela1999 force-pushed the podConfig branch 2 times, most recently from 392ae22 to cb2f142 Compare January 19, 2023 07:45
Signed-off-by: vineela1999 <vineelapachipulusu@gmail.com>
Copy link
Collaborator

@AmitRoushan AmitRoushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushanthakumar sushanthakumar merged commit e793b04 into soda-cdm:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup handling for all the scenarios of configmap and secret usage
3 participants