Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloud] Fix freshness value to be an int milliseconds #1164

Closed
vijaykiran opened this issue Mar 24, 2022 · 1 comment · Fixed by #1338
Closed

[cloud] Fix freshness value to be an int milliseconds #1164

vijaykiran opened this issue Mar 24, 2022 · 1 comment · Fixed by #1338
Assignees

Comments

@vijaykiran
Copy link
Contributor

Freshness check sends the value as str(time delta) this should be milliseconds

{
      "identity": "check-test-workshop_ds-ORDERS-daily-created_at-Freshness-bfdcb2cd",
      "name": "freshness using created_at < 2h",
      "type": "metricThreshold",
      "definition": "checks for ORDERS [daily]:\n  freshness using created_at < 2h",
      "location": {
        "filePath": "checks/02_advanced_and_cool.yml",
        "line": 34,
        "col": 5
      },
      "dataSource": "workshop_ds",
      "table": "ORDERS",
      "column": "created_at",
      "metrics": [
        "metric-test-workshop_ds-ORDERS-daily-created_at-max"
      ],
      "outcome": "fail",
      "diagnostics": {
        "value": "27 days, 2:29:20.044015",
        "maxColumnTimestamp": "2022-02-24 16:25:52",
        "maxColumnTimestampUtc": "2022-02-24 16:25:52+00:00",
        "nowVariableName": "NOW",
        "nowTimestamp": "2022-03-23T18:55:12.044015",
        "nowTimestampUtc": "2022-03-23 18:55:12.044015+00:00",
        "freshness": "27 days, 2:29:20.044015"
      }
    }
@vijaykiran vijaykiran self-assigned this Mar 24, 2022
@milanaleksic
Copy link
Contributor

@vijaykiran please make it microseconds just as in python is currently, that part is not a problem. Perhaps we can later then support milis as well, but if you send millis instead of micros that would also fail current parser: https://github.com/sodadata/soda/blob/52f5bee6825f0e0e91672882d1a25ed61be2c9e9/soda-basics-gson/src/main/java/io/sodadata/basics/gson/DurationConverter.java#L34

@m1n0 m1n0 assigned m1n0 and unassigned vijaykiran May 10, 2022
m1n0 added a commit that referenced this issue May 16, 2022
m1n0 added a commit that referenced this issue May 16, 2022
vijaykiran pushed a commit that referenced this issue May 16, 2022
* Freshness send microseconds to cloud.


Fix #1164
linderttobias pushed a commit to linderttobias/soda-core that referenced this issue Sep 14, 2022
* Freshness send microseconds to cloud.


Fix sodadata#1164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants