-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cloud] Fix freshness value to be an int milliseconds #1164
Comments
@vijaykiran please make it microseconds just as in python is currently, that part is not a problem. Perhaps we can later then support milis as well, but if you send millis instead of micros that would also fail current parser: https://github.com/sodadata/soda/blob/52f5bee6825f0e0e91672882d1a25ed61be2c9e9/soda-basics-gson/src/main/java/io/sodadata/basics/gson/DurationConverter.java#L34 |
m1n0
added a commit
that referenced
this issue
May 16, 2022
m1n0
added a commit
that referenced
this issue
May 16, 2022
vijaykiran
pushed a commit
that referenced
this issue
May 16, 2022
* Freshness send microseconds to cloud. Fix #1164
linderttobias
pushed a commit
to linderttobias/soda-core
that referenced
this issue
Sep 14, 2022
* Freshness send microseconds to cloud. Fix sodadata#1164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Freshness check sends the value as
str(time delta)
this should be millisecondsThe text was updated successfully, but these errors were encountered: