Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error message for non existing data source #1169

Closed
m1n0 opened this issue Mar 25, 2022 · 1 comment · Fixed by #1291
Closed

Bad error message for non existing data source #1169

m1n0 opened this issue Mar 25, 2022 · 1 comment · Fixed by #1291
Assignees
Labels
bug Something isn't working

Comments

@m1n0
Copy link
Contributor

m1n0 commented Mar 25, 2022

soda scan -d does_not_exist -c configuration.yml checks.yml

results in

Soda Core 3.0.0b4
Unknown error while executing scan.
  | dictionary changed size during iteration
  | Stacktrace:
  | Traceback (most recent call last):
  |   File "/Users/m1n0/dev/soda/soda-sql/soda-core/soda/core/soda/scan.py", line 267, in execute
  |     for data_source_scan_cfg in self._sodacl_cfg.data_source_scan_cfgs.values():
  | RuntimeError: dictionary changed size during iteration
@tombaeyens tombaeyens added the bug Something isn't working label Mar 28, 2022
@tombaeyens tombaeyens changed the title Fix error message when non existing data source is specified Bad error message for non existing data source Mar 28, 2022
@tombaeyens
Copy link
Contributor

tombaeyens commented Mar 28, 2022

Data source "does_not_exist" does not exist. should be added as an error to the logs.
No stack trace should be shown (unless -V).

@m1n0 m1n0 self-assigned this Apr 22, 2022
m1n0 added a commit that referenced this issue Apr 22, 2022
m1n0 added a commit that referenced this issue Apr 22, 2022
vijaykiran pushed a commit that referenced this issue Apr 22, 2022
linderttobias pushed a commit to linderttobias/soda-core that referenced this issue Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants