Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace should not return same list if newItem is falsy #258

Closed
anduong96 opened this issue Feb 17, 2023 · 0 comments · Fixed by #309
Closed

replace should not return same list if newItem is falsy #258

anduong96 opened this issue Feb 17, 2023 · 0 comments · Fixed by #309
Labels
bug Something isn't working

Comments

@anduong96
Copy link

Use case:

const newList = replace(myNumberList, 0, el => el !== 0)

newList here does not return expected result
@sodiray sodiray added the bug Something isn't working label Jun 26, 2023
@sodiray sodiray mentioned this issue Jun 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace escape condition on falsy values sodiray/radash
2 participants
@anduong96 @sodiray