Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace escape condition on falsy values #309

Merged
merged 2 commits into from
Jun 26, 2023
Merged

fix: replace escape condition on falsy values #309

merged 2 commits into from
Jun 26, 2023

Conversation

sodiray
Copy link
Owner

@sodiray sodiray commented Jun 26, 2023

Description

See #258

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves #258

@vercel
Copy link

vercel bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 10:41pm

@sodiray sodiray merged commit 28f8114 into master Jun 26, 2023
@sodiray sodiray deleted the fix/replace-escape-condition branch June 27, 2023 13:37
aleclarson referenced this pull request in radashi-org/radashi Jun 24, 2024
@sodiray @aleclarson
fix: replace escape condition on falsy values (#309)
e4e98c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace should not return same list if newItem is falsy
1 participant
@sodiray