Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling mistake in clone page #240

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

isaac0798
Copy link
Contributor

Description

Just noticed a small spelling mistake in the clone page

Checklist

  • [✅] Changes are covered by tests if behavior has been changed or added
  • [✅] Tests have 100% coverage
  • [✅] If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • [✅] If code changes were made, the documentation (in the /docs directory) has been updated

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 6:10PM (UTC)

Copy link
Owner

@sodiray sodiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @isaac0798 one small item needs to be addressed before merging.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "radash",
"version": "10.7.0",
"version": "10.7.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a documentation fix we don't want to change the library version. We'll need to revert this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted this 👍

@sodiray sodiray merged commit 7c6b986 into sodiray:master Jan 20, 2023
aleclarson referenced this pull request in radashi-org/radashi Jun 24, 2024
* fix spelling mistake in clone page

* reverting version bump

Co-authored-by: Isaac Tennant <isaactennant@Isaacs-MBP.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants