assign should keep unique values
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apstanisic
commented
Feb 7, 2023
| })() | ||
| } | ||
| }, {} as X) | ||
| if (!initial || !override) return initial ?? override ?? {} |
There was a problem hiding this comment.
I changed this to one liner to save few bytes. Should I revert it?
There was a problem hiding this comment.
It's a bit different style but still clean, I like it, let's keep it.
|
Any news on this? I have a really ugly temp implementation in my codebase at the moment, waiting until this gets merged in so I can remove it, would be a shame if this PR went stale. |
|
@tsa96 and @apstanisic I'm merging this. Appreciate the contribution and the patience 🙏 it will be available later today when v11.0.0 is published. |
aleclarson
referenced
this pull request
in radashi-org/radashi
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
assignshould keep unique properties of both object.issue reproduction example
Checklist
package.jsonhas been bumped (matching semver)yarn buildcommand has been run and to update thecdndirectory/docsdirectory) has been updatedResolves
Resolves #247