(fix) Forgot to check learner replicator. #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
approved these changes
Dec 30, 2019
fengjiachun
pushed a commit
that referenced
this pull request
Jan 1, 2020
* (fix) Forgot to check learner replicator. * (feat) Only print log when targetPriority value was changed
zongtanghu
pushed a commit
that referenced
this pull request
Apr 28, 2020
* (fix) Forgot to check learner replicator. * (feat) Only print log when targetPriority value was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If the learner node is not started when a new leader is elected, then the replicator to this learner will not be created, so the new logs will not be replicated to this learner even when it is started in future.
Modification:
We should check learner replicator state in stepdown timeout handler, just like checking the follower replicator in
checkDeadNodes0.