Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl doing snapshot sync in StateMachine callback methods. #827

Merged
merged 3 commits into from
May 25, 2022

Conversation

killme2008
Copy link
Contributor

Motivation:

Try to fix #774 , provide a method to trigger a snapshot in StateMachine's callback methods synchronously.

Modification:

TODO

@killme2008 killme2008 requested review from fengjiachun and zongtanghu and removed request for fengjiachun May 7, 2022 11:16
@hzh0425 hzh0425 self-requested a review May 13, 2022 10:40
@killme2008 killme2008 changed the title [WIP] feat: impl doing snapshot sync in StateMachine callback methods. feat: impl doing snapshot sync in StateMachine callback methods. May 15, 2022
Copy link
Member

@hzh0425 hzh0425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Contributor Author

@fengjiachun 这个有空你也看下,可以合并了。对于 closure 的处理,我也准备在此基础上做个重构。

@fengjiachun
Copy link
Contributor

@fengjiachun 这个有空你也看下,可以合并了。对于 closure 的处理,我也准备在此基础上做个重构。

好的,我会尽快看下

Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit a3ed1f7 into master May 25, 2022
@fengjiachun fengjiachun deleted the feature/snapshot-sync branch May 25, 2022 02:19
@fengjiachun fengjiachun restored the feature/snapshot-sync branch May 25, 2022 02:19
@fengjiachun fengjiachun deleted the feature/snapshot-sync branch May 25, 2022 02:19
@killme2008 killme2008 mentioned this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

按照固定间隔index 进行snapshot
3 participants