Grpc Support #383
Closed
Grpc Support #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # extension-impl/tracer-opentracing/src/test/java/com/alipay/sofa/rpc/tracer/sofatracer/base/AbstractTracerBase.java # test/test-integration/src/test/java/com/alipay/sofa/rpc/server/rest/RestTracerTest.java
|
文档的 PR 也请同步提交哈。 @NeGnail |
|
恩呐，文档也会提的。 |
|
GRPC需要jdk7以上版本。 这里CI跑jdk6所以挂了。 |
|
ok。那这个版本开始就可以去掉6的ci了。 |
|
恩，等下周5.4.8 发布后，有了 jdk8的分支，这个再合并。 |
Closed
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
=========================================
Coverage ? 71.19%
Complexity ? 1150
=========================================
Files ? 375
Lines ? 15674
Branches ? 2517
=========================================
Hits ? 11159
Misses ? 3174
Partials ? 1341
Continue to review full report at Codecov.
|
|
暂时别合。今天我优化一下。 |
嗯，只是解决了一下冲突。和hytrix和nocos的代码pom有冲突。 |
2）Support for server-side streaming calls.
ujjboy
reviewed
May 22, 2019
| @@ -66,6 +69,41 @@ | |||
| */ | |||
| private static final Map<Class, Class> PROXY_CLASS_MAP = new ConcurrentHashMap<Class, Class>(); | |||
|
|
|||
| public <T> T getProxyForClass(final Class<T> clazz, final Invoker proxyInvoker) { | |||
|
@NeGnail 解决下冲突 |
| try { | ||
| // 关闭端口，不关闭线程池 | ||
| if (LOGGER.isInfoEnabled()) { | ||
| LOGGER.info("Stop the http rest server at port {}", serverConfig.getPort()); |
There was a problem hiding this comment.
should change rest to grpc ??
| } | ||
| server.shutdown(); | ||
| } catch (Exception e) { | ||
| LOGGER.error("Stop the http rest server at port " + serverConfig.getPort() + " error !", e); |
There was a problem hiding this comment.
should change rest to grpc ??
| try { | ||
| server.start(); | ||
| if (LOGGER.isInfoEnabled()) { | ||
| LOGGER.info("Start the http rest server at port {}", serverConfig.getPort()); |
There was a problem hiding this comment.
should change rest to grpc ??
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Support GRPC.
Modification:
Provides the GRPC bootstrap(consumer/provider), server, client transport and other abstractions
Add proxy for GRPC base class.
The stub for GRPC is abstracted mainly at the Transport layer.
update sofa-tracer version to 2.1.2.
update guava version to 20.0.
Result:
Trace back to the #57
Docking of the main modes of use. Set up the basic architecture for GRPC's more complete extension in sofarpc.
Next we can support tracer and client-side streaming calls.