test:add compatible test case #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizhiyuan
requested review from
khotyn,
ujjboy,
JervyShi,
zonghaishang and
NeGnail
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
=========================================
Coverage ? 71.78%
Complexity ? 1089
=========================================
Files ? 376
Lines ? 15405
Branches ? 2466
=========================================
Hits ? 11059
Misses ? 3067
Partials ? 1279Continue to review full report at Codecov.
|
ujjboy
reviewed
Nov 27, 2019
| @@ -44,15 +43,15 @@ public void encode() throws Exception { | |||
| map.put("a", ""); | |||
| map.put("b", null); | |||
| bs = simpleMapSerializer.encode(map); | |||
| Assert.assertEquals(37, bs.length); | |||
| Assert.assertEquals(28, bs.length); | |||
There was a problem hiding this comment.
key和value为null的都不写了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
add compatible test case for #808
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.