Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from the keywords of service name. #95

Merged
merged 2 commits into from
May 6, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented May 6, 2018

Fix #89

@ujjboy ujjboy added the enhancement New feature or request label May 6, 2018
@ujjboy ujjboy added this to the 5.4.0 milestone May 6, 2018
@codecov-io
Copy link

codecov-io commented May 6, 2018

Codecov Report

Merging #95 into master will increase coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
+ Coverage     63.84%   63.86%   +0.01%     
  Complexity      602      602              
============================================
  Files           265      265              
  Lines         11333    11338       +5     
  Branches       1897     1899       +2     
============================================
+ Hits           7236     7241       +5     
  Misses         3122     3122              
  Partials        975      975
Impacted Files Coverage Δ Complexity Δ
.../sofa/rpc/bootstrap/DefaultClientProxyInvoker.java 74.19% <0%> (ø) 0 <0> (ø) ⬇️
...lipay/sofa/rpc/config/AbstractInterfaceConfig.java 46.81% <100%> (+0.24%) 0 <0> (ø) ⬇️
...pay/sofa/rpc/config/ConfigUniqueNameGenerator.java 93.75% <100%> (+2.08%) 0 <0> (ø) ⬇️
...ipay/sofa/rpc/server/rest/SofaResourceFactory.java 62.5% <100%> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b5ec4...77f88a3. Read the comment docs.

@ujjboy ujjboy merged commit 970f76c into sofastack:master May 6, 2018
@ujjboy ujjboy deleted the fix_issue_89 branch May 6, 2018 07:45
@ujjboy ujjboy mentioned this pull request May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants