Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logging.file.path #430

Merged
merged 5 commits into from
Apr 15, 2021

Conversation

glmapper
Copy link
Contributor

FIX #416

@glmapper glmapper added this to the 3.1.1 milestone Feb 24, 2021
@khotyn
Copy link
Member

khotyn commented Feb 24, 2021

@glmapper The Codecov result is not generated in this thread, is there something wrong with our Codecov configuration?

Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #430 (25ec484) into master (2bbe3ba) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #430      +/-   ##
============================================
+ Coverage     46.28%   46.30%   +0.02%     
  Complexity      219      219              
============================================
  Files           331      331              
  Lines          9914     9916       +2     
  Branches        942      943       +1     
============================================
+ Hits           4589     4592       +3     
+ Misses         4841     4840       -1     
  Partials        484      484              
Impacted Files Coverage Δ Complexity Δ
...mmon/tracer/core/appender/TracerLogRootDaemon.java 60.00% <50.00%> (-0.87%) 0.00 <0.00> (ø)
.../tracer/core/reporter/digest/DiskReporterImpl.java 87.03% <0.00%> (+3.70%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbe3ba...25ec484. Read the comment docs.

@glmapper glmapper self-assigned this Apr 15, 2021
@glmapper glmapper added the enhancement New feature or request label Apr 15, 2021
@glmapper glmapper requested a review from khotyn April 15, 2021 14:26
@glmapper glmapper merged commit cdbde41 into sofastack:master Apr 15, 2021
@glmapper glmapper deleted the support-logging.file.path branch April 15, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spring boot 2.x logging.path 过期
3 participants