Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dashes in filenames #448

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Conversation

m5r
Copy link
Contributor

@m5r m5r commented Feb 25, 2023

Describe your changes

Fixes #447

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

…Manifest

* quote keys for `previews` and `templates` to work with dashes in filenames
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2023

🦋 Changeset detected

Latest commit: 348c086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mailing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 25, 2023

@m5r is attempting to deploy a commit to the sofn Team on Vercel.

A member of the Team first needs to authorize it.

@alexfarrill
Copy link
Collaborator

Thanks for the PR @m5r ! I'm taking a look and if it works, I'll plan to include in the next release (today). Thanks for using Mailing!
Alex

@alexfarrill alexfarrill merged commit 7f6170d into sofn-xyz:main Feb 27, 2023
@m5r m5r deleted the camel-case-module-names branch March 2, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template files with dashes - produce invalid code for moduleManifest.ts
2 participants