Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump to next 14 in peer deps #488

Merged
merged 2 commits into from
Dec 4, 2023
Merged

fix: bump to next 14 in peer deps #488

merged 2 commits into from
Dec 4, 2023

Conversation

KATT
Copy link
Contributor

@KATT KATT commented Nov 26, 2023

Describe your changes

Bump to next 14 peer deps

Issue link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

Copy link

changeset-bot bot commented Nov 26, 2023

⚠️ No Changeset found

Latest commit: a21cbfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 26, 2023

@KATT is attempting to deploy a commit to the sofn Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: next@13.5.6

@@ -42,7 +42,7 @@
"node-mocks-http": "^1.11.0"
},
"peerDependencies": {
"next": "^12.0.0 || ^13.0.0",
"next": "^12.0.0 || ^13.0.0 || ^14.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda think this could be

Suggested change
"next": "^12.0.0 || ^13.0.0 || ^14.0.0",
"next": ">= 12.0.0",

They're pretty good at backwards compat and likely won't drop the /pages-router for a long time

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mailing-dynamic-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 6:51pm
web-emails ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 6:51pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mailing-web ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 6:51pm

@psugihara
Copy link
Collaborator

Merging this now and will fix tests and release today. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants