Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad conditional when added error message #494

Merged
merged 1 commit into from
May 14, 2024

Conversation

potofpie
Copy link
Contributor

@potofpie potofpie commented Apr 12, 2024

Describe your changes

Currently the error will always be request body without the additional text. I believe the intension of the code was to append "querystring" or "request body" depending on the method.

Issue link

I discovered this issue while trying to debug another issue and did not understand why I was getting a error message about the body when I was sending a GET request.

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: e49277e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 12, 2024

@potofpie is attempting to deploy a commit to the sofn Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@jaredkgrove jaredkgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed

@potofpie potofpie closed this May 3, 2024
@potofpie
Copy link
Contributor Author

potofpie commented May 3, 2024

You should still add this. I just hate having this in the list of my PRs

@psugihara psugihara reopened this May 14, 2024
@psugihara
Copy link
Collaborator

sorry i didn't see this! testing

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mailing-dynamic-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 6:45pm
web-emails ❌ Failed (Inspect) May 14, 2024 6:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mailing-web ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 6:45pm

@psugihara
Copy link
Collaborator

test failure is a snapshotted date, whoops :)

@psugihara psugihara enabled auto-merge (squash) May 14, 2024 18:50
@psugihara psugihara disabled auto-merge May 14, 2024 18:50
@psugihara psugihara merged commit 90af52d into sofn-xyz:main May 14, 2024
9 of 11 checks passed
@psugihara
Copy link
Collaborator

big thanks for the small fix, @potofpie and appreciate the testing @jaredkgrove!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants