Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Ensure open handles lists correctly #316

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jakirkham
Copy link
Contributor

Fixes #310

The call to glob was causing lists of files to fail in open. This fixes that issue by looping over the lists contents and concatenating them.

The call to `glob` was causing `list`s of files to fail in `open`. This
fixes that issue by looping over the `list`s contents, calling `glob` on
each one, and concatenating them into a list of files.
@jakirkham jakirkham changed the title Ensure open handles lists correctly WIP: Ensure open handles lists correctly Jan 6, 2019
@rbnvrw
Copy link
Contributor

rbnvrw commented Oct 16, 2019

@jakirkham is this PR still up to date?
Did you see the suggestion made in the referenced issue? #310 (comment)
If you could update the PR, I'll be happy to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pims.open should handle lists of URLs
2 participants