Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete list of supported bioformats filetypes #357

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GenevieveBuckley
Copy link
Contributor

I was trying to open a deltavision .dv image file the other day and found that the bioformats reader doesn't recognise all bioformats filetypes. This means that the pims.open() command won't call out to the bioformats reader.

Even ahough you can force it to open correctly by calling pims.Bioformats() instead of pims.open(), this isn't ideal for downstream libraries/users (eg: dask-image uses pims.opne() and we wouldn't want to implement any extra logic around trying to pick the pims reader ourselves, since pims does that much better).

I got the list of bioformats supported file extensions from https://docs.openmicroscopy.org/bio-formats/5.7.1/supported-formats.html

There is some overlap with file extensions recognized by other readers, but that was true of the last set too & it shouldn't matter since I think the Bioformats reader is tried last.

@nkeim nkeim added this to the v0.6 milestone Jun 8, 2020
@nkeim
Copy link
Contributor

nkeim commented Jun 8, 2020

This is a good idea! I would love to see it in v0.6.

@GenevieveBuckley
Copy link
Contributor Author

Note: this PR needs to specify a relative path to bioformats_filetypes.txt, then the CI should pass

@tacaswell tacaswell closed this Apr 12, 2022
@tacaswell tacaswell reopened this Apr 12, 2022
@tacaswell
Copy link
Member

"power-cycled" to get new CI.

@GenevieveBuckley Is this list still accurate (2 years later)?

@nkeim
Copy link
Contributor

nkeim commented Apr 20, 2022

Looks like this code needs to find bioformats_filetypes.txt via the module path. Once that's done I'm for merging; even if the list is a bit outdated it's still a big enhancement.

@nkeim nkeim mentioned this pull request Apr 20, 2022
4 tasks
@GenevieveBuckley
Copy link
Contributor Author

GenevieveBuckley commented Apr 26, 2022

"power-cycled" to get new CI.

@GenevieveBuckley Is this list still accurate (2 years later)?

I don't know, I haven't looked at it since then.

You could cross check it against the latest (or whichever version pims currently pins to, which is not the one I originally looked at anymore I don't think) https://docs.openmicroscopy.org/bio-formats/latest/supported-formats.html

Alternatively, perhaps it would be better to link directly to that page, either in addition to or instead of maintaining a separate copy of the list here. That would reduce the maintenance burden, although I guess dead links are always a possibility.

@tacaswell
Copy link
Member

Given that this is tied to a version of bioformats and #403 is changing that, I think we should do both together.

I do not think we want have a network hit on import, it is probably best to just embed this list as a (very long) literal in the source (the test failures are failing to open the txt file, not sure if it is cwd related or packaging related...) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants