Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix branch name in link to example nb #428

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

dmarx
Copy link
Contributor

@dmarx dmarx commented Oct 9, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 62.57% // Head: 61.64% // Decreases project coverage by -0.92% ⚠️

Coverage data is based on head (97afebd) compared to base (96bb786).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   62.57%   61.64%   -0.93%     
==========================================
  Files          31       31              
  Lines        4500     4391     -109     
==========================================
- Hits         2816     2707     -109     
  Misses       1684     1684              
Impacted Files Coverage Δ
pims/moviepy_reader.py 56.75% <0.00%> (-4.22%) ⬇️
pims/pyav_reader.py 21.07% <0.00%> (-3.69%) ⬇️
pims/imageio_reader.py 35.86% <0.00%> (-3.31%) ⬇️
pims/cine.py 62.34% <0.00%> (-2.09%) ⬇️
pims/image_reader.py 81.63% <0.00%> (-2.01%) ⬇️
pims/base_frames.py 75.08% <0.00%> (-1.89%) ⬇️
pims/bioformats.py 12.32% <0.00%> (-1.82%) ⬇️
pims/tiff_stack.py 56.05% <0.00%> (-1.33%) ⬇️
pims/norpix_reader.py 86.29% <0.00%> (-0.93%) ⬇️
pims/_version.py 44.65% <0.00%> (-0.42%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nkeim
Copy link
Contributor

nkeim commented Oct 9, 2022

Thanks for the helpful and important fix!!

I'm going to merge this, but tests with the latest matplotlib are failing with PendingDeprecationWarning('The set_tight_layout function will be deprecated in a future version. Use set_layout_engine instead.'). I will create a separate issue about that.

@nkeim nkeim merged commit 5ec734d into soft-matter:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants