Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Item names to vs billing report #1564

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Add Item names to vs billing report #1564

merged 2 commits into from
Nov 15, 2021

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Nov 11, 2021

@allmightyspiff allmightyspiff linked an issue Nov 11, 2021 that may be closed by this pull request
Add Item names to vs billing report #1562
Closed
allmightyspiff
allmightyspiff requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to Capitalize Description in the output table.

Thanks

SoftLayer/CLI/virt/billing.py Outdated Show resolved Hide resolved
allmightyspiff
allmightyspiff approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@allmightyspiff allmightyspiff merged commit a723d16 into softlayer:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@FernandoOjeda FernandoOjeda Awaiting requested review from FernandoOjeda

Assignees

@caberos caberos

Labels
CLI
Projects
No open projects
Q4 2021 (Beta)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Item names to vs billing report
2 participants
@caberos @allmightyspiff