Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new command on autoscale delete #1628

Merged
merged 4 commits into from
May 2, 2022
Merged

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Apr 28, 2022

#1627

command
slcli autoscale delete scalegroupId

@edsonarios
Copy link
Contributor

edsonarios commented Apr 29, 2022

It may be necessary to ask for a confirmation to remove it, for example on dedicatedhost or vlan
image

When we send letters instead of a number, it only returns an exception, but it should return an error message better like in the image or virtual commands, but ideally, specify that the parameter be an integer.
image
image

@allmightyspiff allmightyspiff linked an issue Apr 29, 2022 that may be closed by this pull request
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to change the message output from if/else to a try/catch and this should be good. Also make sure to update the documentation for cli here, as it is copied from the user delete command. Thanks

SoftLayer/CLI/autoscale/delete.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff merged commit f950894 into softlayer:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

slcli autoscale delete
4 participants