Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update volume-refresh command #1832

Merged
merged 17 commits into from
Feb 6, 2023
Merged

update volume-refresh command #1832

merged 17 commits into from
Feb 6, 2023

Conversation

ko101
Copy link
Contributor

@ko101 ko101 commented Jan 18, 2023

No description provided.

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these files to their proper location.

refresh.py should be in SoftLayer/CLI/file/refresh.py
stirage.py should be in SoftLayer/managers/storage.py

@ko101 ko101 closed this Jan 18, 2023
@ko101 ko101 reopened this Jan 18, 2023
@allmightyspiff
Copy link
Member

@ko101 you'll need to make changes to your ko101:master branch before the changes are reflected in this pull request.

These 2 files need to be moved to their proper place in the repository. If that doesn't make sense let me know.

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, just needs some style adjustments. Thanks

SoftLayer/CLI/block/refresh.py Outdated Show resolved Hide resolved
SoftLayer/CLI/file/refresh.py Outdated Show resolved Hide resolved
@allmightyspiff
Copy link
Member

Also, need to wait for this API to release before we merge this change. FBLOCK-4704 is the related issue I believe

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just waiting on the API to be available before merging in, FBLOCK-4704 should be out 2023-02-06

@allmightyspiff allmightyspiff merged commit 0ea78de into softlayer:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Systems
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update command volume-refresh with new feature "force_refresh"
2 participants