Add the retryOnTimeout option

[ValentinH]

As requested in #39

[yns01]

@jlopezxs Did you have a chance to look at this PR? It's related to issue #39

[ValentinH]

Hi @yns01 , I have refactored the timeouts handling a bit: the check for timeouts is only done in one place.

However, now the isNetworkOrIdempotentRequestError() function might not be named correctly and some functions behavior have changed.

[jlopezxs]

This is nice but I think you can do that with retryCondition. I don't know if is good idea start creating Boolean parameters only to apply a "custom retry logic".

[ValentinH]

I understand that we can override the retryCondition with custom logic. However, I ended up copying the isRetryableError, isIdempotentRequestError and isNetworkOrIdempotentRequestError in my code just for removing the checks about error.code !== 'ECONNABORTED'. This doesn't feel right.

I also understand that the solution I propose isn't the best one but I couldn't find another way so far... :/

[ValentinH]

Any chance we could reconsider this PR?

[ValentinH]

It's actually even more important than what I thought and I might want to rename the option to retryOnConnAborted: axios/axios#1543

Indeed, axios uses ECONNABORTED for timeouts but also for actual connections being aborted (for other reasons). This is why we might want to retry in this case.

[mathiasose]

+1, I would also like to see this feature released.

In the meantime, this config should do the trick right?

axiosRetry(axios, {
  retries: 3,
  shouldResetTimeout: true,
  retryCondition: (error) => isNetworkOrIdempotentRequestError(error) || error.code === 'ECONNABORTED',
});

Technically this config would also retry non-idempotent requests (e.g. POST), but I am only going to use this config with a specific PUT operation, so it should be safe right?

[ruscon]

Have the same issue, can we fix it ?

[eddyson1006]

+1, I would also like to see this feature released.

In the meantime, this config should do the trick right?

axiosRetry(axios, {
  retries: 3,
  shouldResetTimeout: true,
  retryCondition: (error) => isNetworkOrIdempotentRequestError(error) || error.code === 'ECONNABORTED',
});

Technically this config would also retry non-idempotent requests (e.g. POST), but I am only going to use this config with a specific PUT operation, so it should be safe right?

Yeah so far the only solution to retry on timeout.