reintroduce octokit retry and throttling plugins #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im now seeing ncc generate 3 additional files. I need to investigate why before merging |
softprops
commented
Dec 6, 2021
| /* global host */ | ||
| /* eslint-disable block-spacing, no-multi-spaces, brace-style, no-array-constructor, new-cap, no-use-before-define */ | ||
|
|
||
| 'use strict'; |
There was a problem hiding this comment.
ncc is now generating these files and I don't know why
|
@softprops any update on this PR? It would be great to have this retry feature!! 🙏 |
Puneeth-n
reviewed
Jan 21, 2022
| const gh = getOctokit(config.github_token, { | ||
| //new oktokit( | ||
| const OctokitWithPlugins = Octokit.plugin(retry, throttling); | ||
| const gh = new OctokitWithPlugins({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the last stream up updates came an upgrade to the
@actions/githubpackage which made it difficult to configure plugins as one normally would with octokit.This had the effect of disabling automatic retry behavior with now has become a feature request.
It would seem the community around these actions octokit integrations with actions has moving around and there's a suggestion here to avoid using
@actions/githuband use@octokit/actioninstead. I don't have a personal preference so long as the result ends up playing nicer with the octokit ecosystem