Add `mouseButton` prop #2676

m-bert · 2023-11-17T08:47:25Z

Description

After giving it some thought, we decided to add new modifier to our handlers - mouseButton. This way users will be able to choose mouse buttons that handler will respond to.

For now this prop is available on all handlers, but it is a topic for a short discussion.

I think it is also worth to mention, that right now all three mouse buttons work on web, so this prop will allow us to 'disable' all buttons except those provided as arguments.

This PR also adds two small examples (one for buttons and one for context menu) that can be used to test given prop on other platforms (when this functionality will be added)

Test plan

Tested on example app.

src/web/handlers/FlingGestureHandler.ts

src/web/tools/PointerEventManager.ts

src/web/tools/GestureHandlerWebDelegate.ts

src/web/interfaces.ts

src/web/handlers/GestureHandler.ts

example/src/App.tsx

example/src/release_tests/mouseButtons/index.tsx

src/web/tools/TouchEventManager.ts

example/src/release_tests/contextMenu/index.tsx

example/src/release_tests/mouseButtons/index.tsx

src/handlers/gestureHandlerCommon.ts

src/web/tools/GestureHandlerWebDelegate.ts

src/web/handlers/GestureHandler.ts

src/web/handlers/LongPressGestureHandler.ts

src/web/tools/GestureHandlerWebDelegate.ts

This reverts commit 471002e.

src/web/handlers/GestureHandler.ts

…4933) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler) | [`^2.14.1` -> `^2.15.0`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.14.1/2.15.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-gesture-handler (react-native-gesture-handler)</summary> ### [`v2.15.0`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.15.0) [Compare Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.14.1...2.15.0) #### ❗ Important changes - macOS Support by [@HeroBanana](https://togithub.com/HeroBanana) and [@jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2588 - feat: add visionOS support by [@tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-gesture-handler#2743 - Add `mouseButton` prop by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2676 - Migrate Gesture Handler to TurboModule by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2354 #### 🐛 Bug fixes - Add checks for the same instance of handler usage across multiple `GestureDetectors` by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2694 - Remove `didMountComponentsWithRootTag` on the new arch by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2687 - Fix double start when `activateAfterLongPress` is used by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2628 - Reset relevant handler when recognizer gets reset. by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2705 - Fix `inactive` handlers staying at finished state by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2738 - Change functions in windows module file to no-ops. by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2741 - Fix handlers coming back from being cancelled by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2704 - fix: restore ReactMethod annotation by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-gesture-handler#2722 #### 🔢 Miscellaneous - Bump react-devtools-core from 4.27.6 to 4.28.4 in /example by [@dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-gesture-handler#2650 - Add `workflow_dispatch` to workflows by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2295 - Update supported versions in readme and in docs by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2684 - Prevent GH actions trigger on forks, update template by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2696 - Auto add `Platform: MacOS` label when `MacOS` is picked in the issue by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2699 - Change eslint `ban-types` to warning. by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2714 - Fix macOS warning message by [@jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2713 - Bump dependencies to stable React Native 0.73.2 by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2698 - Add macOS app icon by [@jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2723 - Bump follow-redirects from 1.15.3 to 1.15.4 in /e2e/web-tests by [@dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-gesture-handler#2719 #### New Contributors - [@mrousavy](https://togithub.com/mrousavy) made their first contribution in [software-mansion/react-native-gesture-handler#2690 - [@HeroBanana](https://togithub.com/HeroBanana) made their first contribution in [software-mansion/react-native-gesture-handler#2588 - [@fxamauri](https://togithub.com/fxamauri) made their first contribution in [software-mansion/react-native-gesture-handler#2712 - [@jfedak](https://togithub.com/jfedak) made their first contribution in [software-mansion/react-native-gesture-handler#2713 - [@computerjazz](https://togithub.com/computerjazz) made their first contribution in [software-mansion/react-native-gesture-handler#2715 **Full Changelog**: software-mansion/react-native-gesture-handler@2.14.0...2.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>

## Description This PR adds implementation of `mouseButton` prop on android. Since `actionButton` field is available only in API >= 23, we provide full support only for those versions. The only thing that changes for API < 23 is ignoring `ACTION_BUTTON_*`, because we don't want handlers to react to both type of events. Note that it requires [this PR](#2676) to work. ## Test plan Tested on `MouseButtons` example.

…alora-inc#4933) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler) | [`^2.14.1` -> `^2.15.0`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.14.1/2.15.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-gesture-handler (react-native-gesture-handler)</summary> ### [`v2.15.0`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.15.0) [Compare Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.14.1...2.15.0) #### ❗ Important changes - macOS Support by [@HeroBanana](https://togithub.com/HeroBanana) and [@jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2588 - feat: add visionOS support by [@tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-gesture-handler#2743 - Add `mouseButton` prop by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2676 - Migrate Gesture Handler to TurboModule by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2354 #### 🐛 Bug fixes - Add checks for the same instance of handler usage across multiple `GestureDetectors` by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2694 - Remove `didMountComponentsWithRootTag` on the new arch by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2687 - Fix double start when `activateAfterLongPress` is used by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2628 - Reset relevant handler when recognizer gets reset. by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2705 - Fix `inactive` handlers staying at finished state by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2738 - Change functions in windows module file to no-ops. by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2741 - Fix handlers coming back from being cancelled by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2704 - fix: restore ReactMethod annotation by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-gesture-handler#2722 #### 🔢 Miscellaneous - Bump react-devtools-core from 4.27.6 to 4.28.4 in /example by [@dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-gesture-handler#2650 - Add `workflow_dispatch` to workflows by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2295 - Update supported versions in readme and in docs by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2684 - Prevent GH actions trigger on forks, update template by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2696 - Auto add `Platform: MacOS` label when `MacOS` is picked in the issue by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2699 - Change eslint `ban-types` to warning. by [@m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2714 - Fix macOS warning message by [@jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2713 - Bump dependencies to stable React Native 0.73.2 by [@j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2698 - Add macOS app icon by [@jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2723 - Bump follow-redirects from 1.15.3 to 1.15.4 in /e2e/web-tests by [@dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-gesture-handler#2719 #### New Contributors - [@mrousavy](https://togithub.com/mrousavy) made their first contribution in [software-mansion/react-native-gesture-handler#2690 - [@HeroBanana](https://togithub.com/HeroBanana) made their first contribution in [software-mansion/react-native-gesture-handler#2588 - [@fxamauri](https://togithub.com/fxamauri) made their first contribution in [software-mansion/react-native-gesture-handler#2712 - [@jfedak](https://togithub.com/jfedak) made their first contribution in [software-mansion/react-native-gesture-handler#2713 - [@computerjazz](https://togithub.com/computerjazz) made their first contribution in [software-mansion/react-native-gesture-handler#2715 **Full Changelog**: software-mansion/react-native-gesture-handler@2.14.0...2.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>

m-bert added 14 commits November 17, 2023 09:40

Remove context menu

cb67ac2

Add prop

bd3b6a9

Change enum order to match web

441c02c

Change enum

f82e08a

Fix field in TouchEventManager

6e1c651

Implement logic on tap

9731777

Add example

edd5c2c

Merge branch 'main' into @mbert/web-right-click

75f94b2

Change type

eeb5ada

Another type change

f414760

Yet another type change

fd7e0bb

change condition

5373c13

Add check to other gestures

0e2aaf8

Update example

ecfcee2

m-bert marked this pull request as ready for review November 20, 2023 09:03

m-bert requested review from j-piasecki, tomekzaw and jfedak November 20, 2023 09:03

Change View to ScrollView

6284ab3

j-piasecki requested changes Nov 20, 2023

View reviewed changes

m-bert added 7 commits November 21, 2023 08:22

remove console.log

64ff5d4

Change button names

193e240

Change MouseButtons name in App

0cbaebd

Add MouseButton.ALL

f77f453

Rename function

09e11fd

Merge branch 'main' into @mbert/web-right-click

577724b

Merge branch 'main' into @mbert/web-right-click

7501737

m-bert mentioned this pull request Nov 23, 2023

Add mouseButton implementation on Android #2680

Merged

m-bert added 2 commits December 6, 2023 14:21

Merge branch 'main' into @mbert/web-right-click

2d39d22

Merge branch 'main' into @mbert/web-right-click

ac10025

m-bert added 2 commits December 20, 2023 16:23

Remove listeners on handler drop

19aa15b

Update example

063889e

m-bert requested a review from j-piasecki December 20, 2023 15:26

Merge main

5313243

j-piasecki requested changes Jan 15, 2024

View reviewed changes

m-bert added 10 commits January 15, 2024 12:27

Merge branch 'main' into @mbert/web-right-click

47e72e1

Change example

60b8487

Remove EnableContextMenu alias

9ece9f9

Remove bounded listeners

2327174

Remove finalize to onDestroy

1da7bfb

Restore default context menu blockade in LongPress

26c4b3c

Add destroy to WebDelegate

8279c90

Restore bounded listeners

471002e

Revert "Restore bounded listeners"

7432cdd

This reverts commit 471002e.

Change binding to this:void

c75fdb7

m-bert requested a review from j-piasecki January 15, 2024 13:24

j-piasecki reviewed Jan 16, 2024

View reviewed changes

src/web/handlers/GestureHandler.ts Outdated Show resolved Hide resolved

Add destroy to delegate interface

f357411

m-bert requested a review from j-piasecki January 16, 2024 10:15

j-piasecki approved these changes Jan 16, 2024

View reviewed changes

m-bert merged commit a30f42f into main Jan 16, 2024
3 checks passed

m-bert deleted the @mbert/web-right-click branch January 16, 2024 13:28

ColeCoffman mentioned this pull request May 21, 2024

[Snyk] Upgrade react-native-gesture-handler from 2.1.3 to 2.16.1 ColeCoffman/JBApp#88

Open

DAVAS110 mentioned this pull request May 24, 2024

[Snyk] Upgrade react-native-gesture-handler from 2.9.0 to 2.16.1 DAVAS110/MyPlant#39

Open

ColeCoffman mentioned this pull request May 25, 2024

[Snyk] Upgrade react-native-gesture-handler from 2.1.3 to 2.16.1 ColeCoffman/JBApp#93

Open

Abellache-Rabah mentioned this pull request May 25, 2024

[Snyk] Upgrade react-native-gesture-handler from 2.9.0 to 2.16.1 Abellache-Rabah/frontend-hawasli#39

Open

ColeCoffman mentioned this pull request Jun 6, 2024

[Snyk] Upgrade react-native-gesture-handler from 2.1.3 to 2.16.2 ColeCoffman/JBApp#98

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `mouseButton` prop #2676

Add `mouseButton` prop #2676

m-bert commented Nov 17, 2023 •

edited

Add mouseButton prop #2676

Add mouseButton prop #2676

Conversation

m-bert commented Nov 17, 2023 • edited

Description

Test plan

Add `mouseButton` prop #2676

Add `mouseButton` prop #2676

m-bert commented Nov 17, 2023 •

edited