Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset relevant handler when recognizer gets reset. #2705

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

j-piasecki
Copy link
Member

Description

At the moment reset method is only called in gestureRecognizerShouldBegin:


However, I've noticed that this method is called after some events are already sent, mainly the BEGIN event, which is often sent as soon as onTouchesBegan is executed for the first pointer.

According to the apple documentation, the reset method of recognizer is the place to reset the internal state of recognizer, which in this case in my opinion should also include the state of the handler.

The issue this fixes is the one described in #2628:

One thing that could be related is the fact that when the gesture fails before activation, the gesture stays in the Began state until the finger is lifted. This still needs to be investigated.

This was coming from the fact that the handler was failing before it was allowed to 'begin' (iOS begin not RNGH begin), so gestureRecognizerShouldBegin was not called, thus not resetting the failing handler. Because of that, it was sending events containing wrong states.

Test plan

Tested on the Example app.

Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apple/Handlers/RNPanHandler.m Show resolved Hide resolved
@j-piasecki j-piasecki merged commit 7581fde into main Jan 10, 2024
3 checks passed
@j-piasecki j-piasecki deleted the @jpiasecki/reset-handlers-with-recognizers branch January 10, 2024 16:20
renovate bot added a commit to valora-inc/wallet that referenced this pull request Feb 17, 2024
…4933)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler)
| [`^2.14.1` ->
`^2.15.0`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.14.1/2.15.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-gesture-handler
(react-native-gesture-handler)</summary>

###
[`v2.15.0`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.15.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.14.1...2.15.0)

#### ❗ Important changes

- macOS Support by [@&#8203;HeroBanana](https://togithub.com/HeroBanana)
and [@&#8203;jfedak](https://togithub.com/jfedak) in
[software-mansion/react-native-gesture-handler#2588
- feat: add visionOS support by
[@&#8203;tomekzaw](https://togithub.com/tomekzaw) in
[software-mansion/react-native-gesture-handler#2743
- Add `mouseButton` prop by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2676
- Migrate Gesture Handler to TurboModule by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2354

#### 🐛 Bug fixes

- Add checks for the same instance of handler usage across multiple
`GestureDetectors` by [@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2694
- Remove `didMountComponentsWithRootTag` on the new arch by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2687
- Fix double start when `activateAfterLongPress` is used by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2628
- Reset relevant handler when recognizer gets reset. by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2705
- Fix `inactive` handlers staying at finished state by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2738
- Change functions in windows module file to no-ops. by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2741
- Fix handlers coming back from being cancelled by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2704
- fix: restore ReactMethod annotation by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-gesture-handler#2722

#### 🔢 Miscellaneous

- Bump react-devtools-core from 4.27.6 to 4.28.4 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[software-mansion/react-native-gesture-handler#2650
- Add `workflow_dispatch` to workflows by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2295
- Update supported versions in readme and in docs by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2684
- Prevent GH actions trigger on forks, update template by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2696
- Auto add `Platform: MacOS` label when `MacOS` is picked in the issue
by [@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2699
- Change eslint `ban-types` to warning. by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2714
- Fix macOS warning message by
[@&#8203;jfedak](https://togithub.com/jfedak) in
[software-mansion/react-native-gesture-handler#2713
- Bump dependencies to stable React Native 0.73.2 by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2698
- Add macOS app icon by [@&#8203;jfedak](https://togithub.com/jfedak) in
[software-mansion/react-native-gesture-handler#2723
- Bump follow-redirects from 1.15.3 to 1.15.4 in /e2e/web-tests by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[software-mansion/react-native-gesture-handler#2719

#### New Contributors

- [@&#8203;mrousavy](https://togithub.com/mrousavy) made their first
contribution in
[software-mansion/react-native-gesture-handler#2690
- [@&#8203;HeroBanana](https://togithub.com/HeroBanana) made their first
contribution in
[software-mansion/react-native-gesture-handler#2588
- [@&#8203;fxamauri](https://togithub.com/fxamauri) made their first
contribution in
[software-mansion/react-native-gesture-handler#2712
- [@&#8203;jfedak](https://togithub.com/jfedak) made their first
contribution in
[software-mansion/react-native-gesture-handler#2713
- [@&#8203;computerjazz](https://togithub.com/computerjazz) made their
first contribution in
[software-mansion/react-native-gesture-handler#2715

**Full Changelog**:
software-mansion/react-native-gesture-handler@2.14.0...2.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
…alora-inc#4933)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler)
| [`^2.14.1` ->
`^2.15.0`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.14.1/2.15.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-gesture-handler
(react-native-gesture-handler)</summary>

###
[`v2.15.0`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.15.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.14.1...2.15.0)

#### ❗ Important changes

- macOS Support by [@&#8203;HeroBanana](https://togithub.com/HeroBanana)
and [@&#8203;jfedak](https://togithub.com/jfedak) in
[software-mansion/react-native-gesture-handler#2588
- feat: add visionOS support by
[@&#8203;tomekzaw](https://togithub.com/tomekzaw) in
[software-mansion/react-native-gesture-handler#2743
- Add `mouseButton` prop by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2676
- Migrate Gesture Handler to TurboModule by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2354

#### 🐛 Bug fixes

- Add checks for the same instance of handler usage across multiple
`GestureDetectors` by [@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2694
- Remove `didMountComponentsWithRootTag` on the new arch by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2687
- Fix double start when `activateAfterLongPress` is used by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2628
- Reset relevant handler when recognizer gets reset. by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2705
- Fix `inactive` handlers staying at finished state by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2738
- Change functions in windows module file to no-ops. by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2741
- Fix handlers coming back from being cancelled by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2704
- fix: restore ReactMethod annotation by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-gesture-handler#2722

#### 🔢 Miscellaneous

- Bump react-devtools-core from 4.27.6 to 4.28.4 in /example by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[software-mansion/react-native-gesture-handler#2650
- Add `workflow_dispatch` to workflows by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2295
- Update supported versions in readme and in docs by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2684
- Prevent GH actions trigger on forks, update template by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2696
- Auto add `Platform: MacOS` label when `MacOS` is picked in the issue
by [@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2699
- Change eslint `ban-types` to warning. by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-gesture-handler#2714
- Fix macOS warning message by
[@&#8203;jfedak](https://togithub.com/jfedak) in
[software-mansion/react-native-gesture-handler#2713
- Bump dependencies to stable React Native 0.73.2 by
[@&#8203;j-piasecki](https://togithub.com/j-piasecki) in
[software-mansion/react-native-gesture-handler#2698
- Add macOS app icon by [@&#8203;jfedak](https://togithub.com/jfedak) in
[software-mansion/react-native-gesture-handler#2723
- Bump follow-redirects from 1.15.3 to 1.15.4 in /e2e/web-tests by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[software-mansion/react-native-gesture-handler#2719

#### New Contributors

- [@&#8203;mrousavy](https://togithub.com/mrousavy) made their first
contribution in
[software-mansion/react-native-gesture-handler#2690
- [@&#8203;HeroBanana](https://togithub.com/HeroBanana) made their first
contribution in
[software-mansion/react-native-gesture-handler#2588
- [@&#8203;fxamauri](https://togithub.com/fxamauri) made their first
contribution in
[software-mansion/react-native-gesture-handler#2712
- [@&#8203;jfedak](https://togithub.com/jfedak) made their first
contribution in
[software-mansion/react-native-gesture-handler#2713
- [@&#8203;computerjazz](https://togithub.com/computerjazz) made their
first contribution in
[software-mansion/react-native-gesture-handler#2715

**Full Changelog**:
software-mansion/react-native-gesture-handler@2.14.0...2.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants