-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: types for gestureHandlerRootHOC #2712
fix: types for gestureHandlerRootHOC #2712
Conversation
## Description While looking at #2711 we decided to change `P extends Record<string, unknown>` to `P extends object` (issue author already created #2712). However, current CI won't allow this change because of `ban-types` eslint rule. I've decided to follow @tjzel suggestion and change this rule to warning instead of error. ## Test plan Run `yarn lint:js-root`.
Hi @fxamauri! Thanks for this PR! Could you please merge latest |
Thanks for adjusting the lint rules, it ended up going unnoticed, I performed a sync with main. |
It required one more formatting change so I decided to do it right away. Thanks for submitting this PR! |
## Description fix gestureHandlerRootHOC type error props declared as an interface Fixes #2711 ## Test plan Check type gestureHandlerRootHOC --------- Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>
…4933) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler) | [`^2.14.1` -> `^2.15.0`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.14.1/2.15.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-gesture-handler (react-native-gesture-handler)</summary> ### [`v2.15.0`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.15.0) [Compare Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.14.1...2.15.0) #### ❗ Important changes - macOS Support by [@​HeroBanana](https://togithub.com/HeroBanana) and [@​jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2588 - feat: add visionOS support by [@​tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-gesture-handler#2743 - Add `mouseButton` prop by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2676 - Migrate Gesture Handler to TurboModule by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2354 #### 🐛 Bug fixes - Add checks for the same instance of handler usage across multiple `GestureDetectors` by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2694 - Remove `didMountComponentsWithRootTag` on the new arch by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2687 - Fix double start when `activateAfterLongPress` is used by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2628 - Reset relevant handler when recognizer gets reset. by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2705 - Fix `inactive` handlers staying at finished state by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2738 - Change functions in windows module file to no-ops. by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2741 - Fix handlers coming back from being cancelled by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2704 - fix: restore ReactMethod annotation by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-gesture-handler#2722 #### 🔢 Miscellaneous - Bump react-devtools-core from 4.27.6 to 4.28.4 in /example by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-gesture-handler#2650 - Add `workflow_dispatch` to workflows by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2295 - Update supported versions in readme and in docs by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2684 - Prevent GH actions trigger on forks, update template by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2696 - Auto add `Platform: MacOS` label when `MacOS` is picked in the issue by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2699 - Change eslint `ban-types` to warning. by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2714 - Fix macOS warning message by [@​jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2713 - Bump dependencies to stable React Native 0.73.2 by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2698 - Add macOS app icon by [@​jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2723 - Bump follow-redirects from 1.15.3 to 1.15.4 in /e2e/web-tests by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-gesture-handler#2719 #### New Contributors - [@​mrousavy](https://togithub.com/mrousavy) made their first contribution in [software-mansion/react-native-gesture-handler#2690 - [@​HeroBanana](https://togithub.com/HeroBanana) made their first contribution in [software-mansion/react-native-gesture-handler#2588 - [@​fxamauri](https://togithub.com/fxamauri) made their first contribution in [software-mansion/react-native-gesture-handler#2712 - [@​jfedak](https://togithub.com/jfedak) made their first contribution in [software-mansion/react-native-gesture-handler#2713 - [@​computerjazz](https://togithub.com/computerjazz) made their first contribution in [software-mansion/react-native-gesture-handler#2715 **Full Changelog**: software-mansion/react-native-gesture-handler@2.14.0...2.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
…alora-inc#4933) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-gesture-handler](https://togithub.com/software-mansion/react-native-gesture-handler) | [`^2.14.1` -> `^2.15.0`](https://renovatebot.com/diffs/npm/react-native-gesture-handler/2.14.1/2.15.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-gesture-handler/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-gesture-handler/2.14.1/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-gesture-handler (react-native-gesture-handler)</summary> ### [`v2.15.0`](https://togithub.com/software-mansion/react-native-gesture-handler/releases/tag/2.15.0) [Compare Source](https://togithub.com/software-mansion/react-native-gesture-handler/compare/2.14.1...2.15.0) #### ❗ Important changes - macOS Support by [@​HeroBanana](https://togithub.com/HeroBanana) and [@​jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2588 - feat: add visionOS support by [@​tomekzaw](https://togithub.com/tomekzaw) in [software-mansion/react-native-gesture-handler#2743 - Add `mouseButton` prop by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2676 - Migrate Gesture Handler to TurboModule by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2354 #### 🐛 Bug fixes - Add checks for the same instance of handler usage across multiple `GestureDetectors` by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2694 - Remove `didMountComponentsWithRootTag` on the new arch by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2687 - Fix double start when `activateAfterLongPress` is used by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2628 - Reset relevant handler when recognizer gets reset. by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2705 - Fix `inactive` handlers staying at finished state by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2738 - Change functions in windows module file to no-ops. by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2741 - Fix handlers coming back from being cancelled by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2704 - fix: restore ReactMethod annotation by [@​WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-gesture-handler#2722 #### 🔢 Miscellaneous - Bump react-devtools-core from 4.27.6 to 4.28.4 in /example by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-gesture-handler#2650 - Add `workflow_dispatch` to workflows by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2295 - Update supported versions in readme and in docs by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2684 - Prevent GH actions trigger on forks, update template by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2696 - Auto add `Platform: MacOS` label when `MacOS` is picked in the issue by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2699 - Change eslint `ban-types` to warning. by [@​m-bert](https://togithub.com/m-bert) in [software-mansion/react-native-gesture-handler#2714 - Fix macOS warning message by [@​jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2713 - Bump dependencies to stable React Native 0.73.2 by [@​j-piasecki](https://togithub.com/j-piasecki) in [software-mansion/react-native-gesture-handler#2698 - Add macOS app icon by [@​jfedak](https://togithub.com/jfedak) in [software-mansion/react-native-gesture-handler#2723 - Bump follow-redirects from 1.15.3 to 1.15.4 in /e2e/web-tests by [@​dependabot](https://togithub.com/dependabot) in [software-mansion/react-native-gesture-handler#2719 #### New Contributors - [@​mrousavy](https://togithub.com/mrousavy) made their first contribution in [software-mansion/react-native-gesture-handler#2690 - [@​HeroBanana](https://togithub.com/HeroBanana) made their first contribution in [software-mansion/react-native-gesture-handler#2588 - [@​fxamauri](https://togithub.com/fxamauri) made their first contribution in [software-mansion/react-native-gesture-handler#2712 - [@​jfedak](https://togithub.com/jfedak) made their first contribution in [software-mansion/react-native-gesture-handler#2713 - [@​computerjazz](https://togithub.com/computerjazz) made their first contribution in [software-mansion/react-native-gesture-handler#2715 **Full Changelog**: software-mansion/react-native-gesture-handler@2.14.0...2.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
Description
fix gestureHandlerRootHOC type error props declared as an interface
Fixes #2711
Test plan
Check type gestureHandlerRootHOC