Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement aux_data callback #1186

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Implement aux_data callback #1186

merged 1 commit into from
Mar 18, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Mar 13, 2024 •
edited
Loading

@maciektr maciektr mentioned this pull request Mar 13, 2024
Merged
@maciektr maciektr marked this pull request as ready for review March 14, 2024 00:20
@maciektr maciektr requested a review from szymmis as a code owner March 14, 2024 00:20
@maciektr maciektr mentioned this pull request Mar 14, 2024
Closed
@maciektr maciektr requested a review from mkaput March 14, 2024 00:21
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
@maciektr
Remove macro_commons (#1185)
f87f290 
commit-id:6c362eae

---

**Stack**:
- #1186
- #1185 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/6c362eae to main March 14, 2024 10:37
@maciektr maciektr requested a review from mkaput March 14, 2024 11:05
@maciektr maciektr force-pushed the spr/main/a9ba1335 branch 2 times, most recently from 69004fd to bffe878 Compare March 14, 2024 12:49
@maciektr maciektr mentioned this pull request Mar 14, 2024
Merged
@maciektr maciektr changed the base branch from main to spr/main/eacd6dd6 March 14, 2024 12:49
This was referenced Mar 14, 2024
Merged
Merged
@maciektr maciektr requested review from drknzz and removed request for szymmis March 15, 2024 13:12
@maciektr maciektr mentioned this pull request Mar 15, 2024
Merged
mkaput
mkaput requested changes Mar 15, 2024
View reviewed changes
plugins/cairo-lang-macro-attributes/src/lib.rs Outdated Show resolved Hide resolved
plugins/cairo-lang-macro/src/lib.rs Outdated Show resolved Hide resolved
plugins/cairo-lang-macro/src/lib.rs Outdated Show resolved Hide resolved
scarb/tests/build_cairo_plugin.rs Outdated Show resolved Hide resolved
github-merge-queue bot pushed a commit that referenced this pull request Mar 15, 2024
@maciektr
Move Scarb StableHash to separate crate (#1187)
fd27eac 
**Stack**:
- #1194
- #1192
- #1186
- #1188
- #1187 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr mentioned this pull request Mar 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 15, 2024
@maciektr
Store AuxData as Vec<u8> instead of serde/string (#1188)
1b4f7aa 
commit-id:eacd6dd6

---

**Stack**:
- #1195
- #1194
- #1192
- #1186
- #1188 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/eacd6dd6 to main March 15, 2024 19:48
@maciektr maciektr mentioned this pull request Mar 18, 2024
Merged
@maciektr maciektr force-pushed the spr/main/a9ba1335 branch 3 times, most recently from 7e5f15a to 5b260a2 Compare March 18, 2024 14:12
@maciektr maciektr requested a review from mkaput March 18, 2024 14:12
mkaput
mkaput requested changes Mar 18, 2024
View reviewed changes
scarb/tests/build_cairo_plugin.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/host.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/host.rs Outdated Show resolved Hide resolved
plugins/cairo-lang-macro-attributes/src/lib.rs Outdated Show resolved Hide resolved
plugins/cairo-lang-macro/src/lib.rs Outdated Show resolved Hide resolved
@maciektr maciektr requested a review from mkaput March 18, 2024 16:02
@maciektr
Implement aux_data callback
b81bd9c 
commit-id:a9ba1335
@maciektr maciektr enabled auto-merge March 18, 2024 17:34
@maciektr maciektr added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 7328e0f Mar 18, 2024
21 checks passed
@maciektr maciektr deleted the spr/main/a9ba1335 branch March 18, 2024 17:48
@BrewTestBot BrewTestBot mentioned this pull request Mar 20, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@drknzz drknzz Awaiting requested review from drknzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciektr @mkaput