Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document registries and packaging process #962

Merged
merged 37 commits into from
Aug 14, 2024
Merged

Document registries and packaging process #962

merged 37 commits into from
Aug 14, 2024

Conversation

szymmis
Copy link
Contributor

@szymmis szymmis commented Nov 30, 2023

Resolves #734 and #901.

@szymmis szymmis linked an issue Nov 30, 2023 that may be closed by this pull request
Document registries #901
Closed
mkaput
mkaput previously requested changes Jan 16, 2024
View reviewed changes
website/docs/registries/package-tarball.md Outdated Show resolved Hide resolved
website/docs/registries/package-tarball.md Outdated Show resolved Hide resolved
website/docs/registries/overview.md Show resolved Hide resolved
website/docs/registries/overview.md Outdated Show resolved Hide resolved
website/docs/registries/overview.md Outdated Show resolved Hide resolved
website/docs/registries/packaging.md Outdated Show resolved Hide resolved
website/docs/registries/packaging.md Outdated Show resolved Hide resolved
@mkaput
Copy link
Member

mkaput commented Jan 16, 2024

We will probably want to merge this after the registry MVP is released

@mkaput mkaput requested a review from DelevoXDG April 3, 2024 11:58
@mkaput mkaput removed the request for review from DelevoXDG April 3, 2024 11:58
maciektr and others added 20 commits May 29, 2024 13:00
@maciektr @mkaput
Update website/docs/registries/package-tarball.md
88a0bf2 
Co-authored-by: Marek Kaput <marek.kaput@swmansion.com>
Signed-off-by: maciektr <mtratnowiecki@gmail.com>
@maciektr @mkaput
Update website/docs/registries/package-tarball.md
2dd2e84 
Co-authored-by: Marek Kaput <marek.kaput@swmansion.com>
Signed-off-by: maciektr <mtratnowiecki@gmail.com>
@maciektr @mkaput
Update website/docs/registries/packaging.md
f679f94 
Co-authored-by: Marek Kaput <marek.kaput@swmansion.com>
Signed-off-by: maciektr <mtratnowiecki@gmail.com>
@DelevoXDG
Merge branch 'main' into szymmis/registry-docs
ab4b05b
@DelevoXDG
Put sentences on separate lines
78d8823
@DelevoXDG
Fix inner links. Use relative links instead of absolute
ea5c24f
@DelevoXDG
Update scarb add docs with registry support info
1ca57c6
@DelevoXDG
Add warning to dependencies guide
4a6ec7c
@DelevoXDG
Update overview.md
3b96144
@DelevoXDG
Fix grammar mistakes in custom-registry.md
840c58b
@DelevoXDG
Change dependencies guide banner from important to warning
7fcc869
@DelevoXDG
Update specifying-dependencies.md and cheatsheet.md to include regist…
68e8a30 
…ry name and link

- Slightly improve wording
@DelevoXDG
Update custom-registry.md to improve phrasing and include registry link
86164dc
@DelevoXDG
Add warning for --no-verify flag in the docs
e5b3c7b
@DelevoXDG
Fix grammar and refine language in packaging.md
2736eac
@DelevoXDG
Fix grammar and refine language in package-tarball.md
dbc7589
@DelevoXDG
Fix grammar and refine language in custom-registry.md
6eacb43
@DelevoXDG
Fix grammar and refine language in overview.md
8f55681
@DelevoXDG
Revert "Merge branch 'main' into szymmis/registry-docs"
3e7ec75 
This reverts commit ab4b05b.
@DelevoXDG
Merge branch 'main' into szymmis/registry-docs
9db5847
@DelevoXDG DelevoXDG requested a review from Arcticae August 6, 2024 16:29
@DelevoXDG DelevoXDG requested review from mkaput and removed request for mkaput August 8, 2024 09:09
@DelevoXDG
Copy link
Contributor

DelevoXDG commented Aug 8, 2024 •
edited
Loading

@mkaput

Can you please approve / TAL, as the requested changes will block the merge? 🙏🏻

Nevermind, I can dismiss the review instead 😄

@DelevoXDG DelevoXDG requested a review from mkaput August 8, 2024 09:29
@DelevoXDG DelevoXDG dismissed mkaput’s stale review August 8, 2024 10:04

All the requested changes were addressed, other other approving reviews are present

@DelevoXDG DelevoXDG removed the request for review from mkaput August 8, 2024 10:05
@DelevoXDG DelevoXDG added this pull request to the merge queue Aug 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 8, 2024
maciektr
maciektr reviewed Aug 12, 2024
View reviewed changes
website/docs/reference/specifying-dependencies.md Outdated Show resolved Hide resolved
website/docs/registries/publishing.md Outdated Show resolved Hide resolved
website/docs/guides/dependencies.md Outdated Show resolved Hide resolved
@THenry14 THenry14 added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 7d24c76 Aug 14, 2024
22 checks passed
@THenry14 THenry14 deleted the szymmis/registry-docs branch August 14, 2024 10:43
@BrewTestBot BrewTestBot mentioned this pull request Aug 28, 2024
Merged
@DelevoXDG DelevoXDG mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DelevoXDG DelevoXDG DelevoXDG left review comments

@maciektr maciektr maciektr left review comments

@THenry14 THenry14 THenry14 approved these changes

@Arcticae Arcticae Arcticae approved these changes

@mkaput mkaput mkaput left review comments

Assignees

@DelevoXDG DelevoXDG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document registries Document packaging infrastructure
6 participants
@szymmis @mkaput @DelevoXDG @THenry14 @maciektr @Arcticae