Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lrp missing rules fixed #14

Merged
merged 5 commits into from
Jan 4, 2023
Merged

lrp missing rules fixed #14

merged 5 commits into from
Jan 4, 2023

Conversation

kamilrzechowski
Copy link
Collaborator

Description

The PR adds missing rules for the LRP explainer, according to the paper.

Some rules for Sigmoid, HardSwish, and Flatten are missing in the LRP captum explainer. The given PR adds gamma rules for initial model layers, epsilon to final model layers, and epsilon=0 rule to the last layer.

Checklist:

  • I have updated all related pyproject.toml files.
  • I have updated lock files.
  • I have set an Assignee and Reviewers.
  • I have labeled the PR correctly.
  • I have performed a self-review of my own code.
  • I have covered my code and changes with unit tests.
  • I have annotated types as extensively as possible.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • All code references and dependencies will work.

@kamilrzechowski kamilrzechowski added the bug Something isn't working label Dec 28, 2022
@kamilrzechowski kamilrzechowski self-assigned this Dec 28, 2022
Copy link
Collaborator

@adamwawrzynski adamwawrzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilrzechowski kamilrzechowski merged commit c3154fd into main Jan 4, 2023
@kamilrzechowski kamilrzechowski deleted the fix/lrp_rules branch January 4, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants