Reworked Schema to be a complete representation of an OpenAPI 3.1 Schema Object #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ghik
commented
Apr 11, 2024
ghik
commented
- added missing keywords (fields) from JSON Schema & OAS 3.1
- removed obsolete (OAS 3.0) fields, while keeping compatibility when encoding/decoding
adamw
reviewed
Apr 12, 2024
adamw
reviewed
Apr 12, 2024
jsonschema-circe/src/main/scala/sttp/apispec/internal/JsonSchemaCirceEncoders.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Apr 12, 2024
|
Looks good! Once merge, this should be 0.9.0. Can you test it with tapir before merging, to see that there are no regressions in tapir's test suite? |
adamw
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.