add setOpenTracingParentSpanContext to OpenTracingBackend #804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting pull request:
sbt compile
sbt compileDocs
sbt test
sbt scalafmt
Adding
setOpenTracingParentSpanContext
toOpenTracingBackend
as we don't usually have the current span available and have to build span context from B3 headers (e.g. in the case of Zipkin).If we create a new Span just so we can pass it to
OpenTracingBackend.setOpenTracingParentSpan
we have unnecessary additional trace/noise in tracing output.Also, there's no way to get Span out from SpanContext per this issue opentracing/specification#81.