Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setOpenTracingParentSpanContext to OpenTracingBackend #804

Merged
merged 1 commit into from
Jan 7, 2021
Merged

add setOpenTracingParentSpanContext to OpenTracingBackend #804

merged 1 commit into from
Jan 7, 2021

Conversation

arun0009
Copy link

@arun0009 arun0009 commented Jan 6, 2021

Before submitting pull request:

  • Check if the project compiles by running sbt compile
  • Verify docs compilation by running sbt compileDocs
  • Check if tests pass by running sbt test
  • Format code by running sbt scalafmt

Adding setOpenTracingParentSpanContext to OpenTracingBackend as we don't usually have the current span available and have to build span context from B3 headers (e.g. in the case of Zipkin).

If we create a new Span just so we can pass it to OpenTracingBackend.setOpenTracingParentSpan we have unnecessary additional trace/noise in tracing output.

Also, there's no way to get Span out from SpanContext per this issue opentracing/specification#81.

@adamw adamw merged commit 13b1553 into softwaremill:master Jan 7, 2021
@adamw
Copy link
Member

adamw commented Jan 7, 2021

Released in 3.0.0-RC15, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants