Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fea] Add a option to choose if use staic runtime library on Windows #220

Merged
merged 2 commits into from
May 19, 2022

Conversation

luciouskami
Copy link
Contributor

@luciouskami luciouskami commented May 18, 2022

See #216
In some cases, we need to compile sprc with static runtime library on windows, and the dependence also need it.
So I add a option to choose if use staic runtime library.

@luciouskami
Copy link
Contributor Author

The pull request has been tested on both Win32 and AMD64 with MSVC.

@holmes1412
Copy link
Contributor

非常感谢!抱歉今天还没有来得及看这块~
我之后会把linux和mac也提取一个cmake参数SRPC_BUILD_STATIC_RUNTIME,ON的话就也对齐windows这个功能。

@luciouskami
Copy link
Contributor Author

非常感谢!抱歉今天还没有来得及看这块~ 我之后会把linux和mac也提取一个cmake参数SRPC_BUILD_STATIC_RUNTIME,ON的话就也对齐windows这个功能。

嗯,我感觉是需要加一个开关的,workflow也是,这样就避免了我们自己编译的静态的库运行库不一致的问题了。

@Barenboim Barenboim merged commit 3313650 into sogou:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants