thrift : fix list<bool> #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from master
Closed
kedixa
reviewed
May 21, 2024
| if (!buffer->readI32(count)) | ||
| return false; | ||
|
|
||
| list->resize(count); |
Comment on lines
+221
to
+227
| for (size_t i = 0; i < list->size(); ++i) | ||
| { | ||
| bool ele; | ||
| if (!val_desc->reader(buffer, &ele)) | ||
| return false; | ||
| (*list)[i] = ele; | ||
| } |
There was a problem hiding this comment.
对于这个场景（由于要求使用C++ 11标准），如果想避免特化class ThriftDescriptorImpl<std::vector<bool>, TDT_LIST, void, VALIMPL>这个很长的类，并且对val_desc的特化的代码更方便，可以将这部分内容实现为
using vector_value_ref = typename T::reference;
for (vector_value_ref ele : *list)
{
// do something with ele
}并对val_desc模板参数std::vector<bool>::reference类型进行特化。注意，这个坏坏的std::vector<bool>::reference看起来是引用，其实它是一个值类型。
|
srpc/src/thrift/rpc_thrift_idl.cc Lines 166 to 167 in 7712ed1 对于输入为LONG_MIN，这里有个有符号数上溢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#381