Support RPC Transcoding for SRPCHttpServer #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holmes1412
changed the title
Barenboim
reviewed
Sep 3, 2024
| @@ -248,26 +248,49 @@ static inline void __set_host_by_uri(const ParsedURI *uri, bool is_ssl, | |||
| } | |||
| } | |||
|
|
|||
| static inline bool __set_request_uri_by_uri(const ParsedURI *uri, | |||
There was a problem hiding this comment.
这里写成const ParsedURI& uri吧。这个类我们好像一般用引用。
There was a problem hiding this comment.
这个主要是用到task->get_current_uri()作为参数，由于返回到是指针，所以相应的内部函数就把参数也写成指针了。
Barenboim
reviewed
Sep 3, 2024
src/rpc_server.h
Outdated
| const json_value_t *v; | ||
| std::string str; | ||
|
|
||
| val = json_value_parse(trans_coding); |
Barenboim
reviewed
Sep 3, 2024
tutorial/tutorial-20-trans_coding.cc
Outdated
| SRPCHttpServer server; | ||
| ExampleServiceImpl impl; | ||
|
|
||
| server.add_service(&impl, "{ \"/test/echo\": \"Echo\"," |
holmes1412
force-pushed
the
master
branch
4 times, most recently
from
50a4c69
to
c87e6b7
Compare
Barenboim
reviewed
Sep 6, 2024
src/rpc_server.h
Outdated
| @@ -49,6 +50,7 @@ class RPCServer : public WFServer<typename RPCTYPE::REQ, | |||
| RPCServer(const struct RPCServerParams *params); | |||
|
|
|||
| int add_service(RPCService *service); | |||
| int add_service(RPCService *service, const char *trans_coding); | |||
|
补充关于trans_code转换的描述，如何将 request_uri通过path_map查找到service和method。 1. initializationserver.add_service(my_example_service, '{ "/echo_a" : "Echo", "/echo_b" : "Echo"}');这里会为server的path_map增加针对example_service的两个映射：
同时，为server的service_map增加一个查找service对象的映射（原有逻辑）：
2. query
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in this issue : #404
TODO: