-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox build support #39
Conversation
@snoyberg Nice. Actually, I started to work on this, too. But as I do TDD, I started with the test case. So there is no duplicate work yet :) I'll be away from my box in 10 minutes, so I'll probably apply it tomorrow. |
Very cool! I just tested this some more, and it looks like it solves the problem with Stackage. I'm going to try a larger build now and see if everything works. |
@snoyberg I implemented the test. I'd still tend to rename the env var to Anything else that we need to sort out before applying this? |
Thanks for including this. The reason I think we shouldn't name this variable DOCTEST is I think it's relevant beyond doctest. For example, I'd like to see cabal-dev set this in general, and other tools like Fay to use it. |
@snoyberg Ok, makes sense. But would then |
Yes, I prefer HASKELL_PACKAGE_SANDBOX. I'll update Stackage to use that. |
Works like a charm, all of Stackage just built cleanly. Thanks! |
Running tests again now. John Wiegley |
This isn't quite ready yet, I still need to get it working correctly with Stackage. I just wanted to send this pull request so you know I'm playing around with this already. I'll ping you on this request when I think it's ready. If you have any comments on the approach I'm taking, let me know.