Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox build support #39

Closed
wants to merge 1 commit into from
Closed

Sandbox build support #39

wants to merge 1 commit into from

Conversation

snoyberg
Copy link
Contributor

This isn't quite ready yet, I still need to get it working correctly with Stackage. I just wanted to send this pull request so you know I'm playing around with this already. I'll ping you on this request when I think it's ready. If you have any comments on the approach I'm taking, let me know.

@sol
Copy link
Owner

sol commented Nov 29, 2012

@snoyberg Nice. Actually, I started to work on this, too. But as I do TDD, I started with the test case. So there is no duplicate work yet :)

I'll be away from my box in 10 minutes, so I'll probably apply it tomorrow.

@snoyberg
Copy link
Contributor Author

Very cool! I just tested this some more, and it looks like it solves the problem with Stackage. I'm going to try a larger build now and see if everything works.

sol added a commit that referenced this pull request Nov 30, 2012
@sol
Copy link
Owner

sol commented Nov 30, 2012

@snoyberg I implemented the test.

I'd still tend to rename the env var to DOCTEST_something, e.g. DOCTEST_PACKAGE_SANDBOX if this works for you?

Anything else that we need to sort out before applying this?

@snoyberg
Copy link
Contributor Author

snoyberg commented Dec 1, 2012

Thanks for including this. The reason I think we shouldn't name this variable DOCTEST is I think it's relevant beyond doctest. For example, I'd like to see cabal-dev set this in general, and other tools like Fay to use it.

@sol
Copy link
Owner

sol commented Dec 1, 2012

@snoyberg Ok, makes sense. But would then HASKELL_PACKAGE_SANDBOX be more appropriate? I don't care too much, I still have the guts feeling that PACKAGE_SANDBOX may be too generic, not sure?

@snoyberg
Copy link
Contributor Author

snoyberg commented Dec 2, 2012

Yes, I prefer HASKELL_PACKAGE_SANDBOX. I'll update Stackage to use that.

@sol
Copy link
Owner

sol commented Dec 2, 2012

@snoyberg @jwiegley Released to Hackage as doctest-0.9.4.

@snoyberg
Copy link
Contributor Author

snoyberg commented Dec 2, 2012

Works like a charm, all of Stackage just built cleanly. Thanks!

@jwiegley
Copy link

jwiegley commented Dec 3, 2012

Simon Hengel notifications@github.com writes:

@snoyberg @jwiegley Released to Hackage as doctest-0.9.4.

Running tests again now.

John Wiegley
FP Complete Haskell tools, training and consulting
http://fpcomplete.com johnw on #haskell/irc.freenode.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants