Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: Eliminate getTokenLargestAccounts queries #210

Closed
steveluscher opened this issue Dec 12, 2022 · 0 comments · Fixed by #270
Closed

explorer: Eliminate getTokenLargestAccounts queries #210

steveluscher opened this issue Dec 12, 2022 · 0 comments · Fixed by #270
Assignees

Comments

@steveluscher
Copy link
Collaborator

steveluscher commented Dec 12, 2022

Problem

Triton One reports that queries of this form:

{
  "method":"getTokenLargestAccounts",
  "jsonrpc":"2.0",
  "params":["EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v", {"commitment":"confirmed"}],
  "id":"b5c5071f-703a-4db6-85d9-90ec4e6102c9"
}

Are dysfunctional in that they:

  1. Require that spl-token-mint be loaded on the RPC servers,
  2. Even so, this results in 5 minute query times which is unusable to begin with.

Example: https://explorer.solana.com/address/EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v/largest

Proposed Solution

Remove all queries of this type from Explorer, like the ‘distribution’ tab on tokens.

@ngundotra ngundotra changed the title Eliminate getTokenLargestAccounts queries from Explorer explorer: Eliminate getTokenLargestAccounts queries Dec 14, 2022
@ngundotra ngundotra transferred this issue from solana-labs/solana Feb 14, 2023
@mcintyre94 mcintyre94 assigned mcintyre94 and unassigned ngundotra Jul 12, 2023
mcintyre94 added a commit that referenced this issue Jul 14, 2023
The token distribution page (address/[address]/largest) was the only use
of `LargestAccountsProvider`. It was nested under `MintsProvider` with
`TokenRegistryProvider`.

So this PR also removes `LargestAccountsProvider` and `MintsProvider`,
and moves `TokenRegistryProvider` to be its own top-level provider. Most
changes are just reflecting that change in the imports.

Closes #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants