Parse feature activation accounts #253
Conversation
|
@terorie is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
I'm not good at frontend, so if this PR needs changes, I suggest a maintainer close this PR and recreate it to save time. Many thanks! |
| </tr> | ||
| ); | ||
| } | ||
| console.log(feature); |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Can you please follow the format for PRs + issues next time? @ripatel-jump Just add a screenshot + a link or two to test the feature you've added would help |
|
Why did you close this PR? |
|
@ngundotra I meant to submit a draft PR, but I mostly just wanted to provide a reference implementation of how this feature could be implemented and save the round trips of review. Would your team be able to take ownership of this and get it to main? Otherwise, will reopen and get it through, and also add human-readable descriptions of the feature accounts. |
|
Thanks for this! I'm concerned to the degree that this UI would only work in two of these three cases:
I worry that this will confuse folks coming to the Explorer in case 3, expecting to see information about a feature, and seeing nothing instead. |
…tivated (#255) This implements: * When a feature has been activated at the epoch boundary for which it was scheduled, we can read out the activation slot and render it in the UI. * When a feature has been scheduled for activation but the activation epoch boundary hasn't been reached, the slot is `none` and we can render ‘not active’ in the UI. This does not implement: * When a feature has not been scheduled at all. Its feature flag account doesn't exist so there's no UI we can show one way or another. _NOTE: Originally made by @terorie as PR #253. I was not able to push to that branch, so had to open a new PR._ --------- Co-authored-by: Richard Patel <ripatel@jumptrading.com>
Adds https://github.com/solana-labs/solana/wiki/Feature-Gate-Activation-Schedule support to UI