jit: correctly load the StableResult discriminant in emit_result_is_err #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
approved these changes
Sep 14, 2023
|
Can we have a test for this? |
Lichtso
force-pushed
the
is-err-discriminant
branch
2 times, most recently
from
823514e
to
ede6335
Compare
alessandrod
commented
Sep 25, 2023
StableResult is #[repr(C, u64)] which means that the layout is [u64 discriminant] [union of all the data carried by the variants] We were accessing the data of the Ok variant.
Lichtso
force-pushed
the
is-err-discriminant
branch
from
ede6335
to
e7bc177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StableResult is #[repr(C, u64)] which means that the layout is:
[u64 discriminant]
[union of all the data carried by the variants]
We were accessing the data of the Ok variant.