stake-pool: Add slippage to all deposit and withdraw ixs #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
going to review this now, just curious, the intent of this is to protect against sandwich attacks, right? wondering if i should make deposit/withdraw always work like this in my program... |
|
Yeah exactly, someone can watch for transactions depositing into the pool and put in an instruction to increase the deposit fee immediately. In your case, I think you don't need it since there's no fees to consider |
|
im imagining a situation where someone does a reasonably large deposit so i frontrun their deposit with my own and backrun a withdrawal |
2501babe
approved these changes
Feb 1, 2023
HaoranYi
pushed a commit
to HaoranYi/solana-program-library
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When depositing and withdrawing from stake pools, it's impossible for a user to guarantee how much they'll receive.
Solution
Add
*WithSlippagevariants to all deposit and withdraw instructions, which guarantee a minimum output, similar to an AMM.