docs: Scrub all references to token-list #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordaaash
previously approved these changes
May 11, 2023
| package, maintained at [https://github.com/solana-labs/token-list](https://github.com/solana-labs/token-list) | ||
| * Hard coded addresses in the wallet or dapp | ||
| * Metaplex Token Metadata. Learn more at the | ||
| [Token Metadata Documentation](https://docs.metaplex.com/programs/token-metadata/) |
There was a problem hiding this comment.
Do we want to link to https://github.com/solana-labs/token-list still from here? It has links and instructions to use some tools to create a token with metadata that might be more helpful than just Metaplex docs for people who aren't familiar with the history of the token list.
There was a problem hiding this comment.
That's a good point... ok, i'll put it back with an EOL warning. Even months later, many people have linked the token-list repo in questions without reading the warning at the top
|
The docs CI passed, which is all that matters -- merging during CI! |
HaoranYi
pushed a commit
to HaoranYi/solana-program-library
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://github.com/solana-labs/token-list has been archived for awhile, but our docs still recommend to use it.
Solution
Change to a link to Metaplex docs. Also, why was it referenced in the name service JS bindings? The world may never know