Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to solana 1.16.3 #4679

Merged

Conversation

samkim-crypto
Copy link
Contributor

No description provided.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to commit the Cargo.lock changes, and be sure to maintain borsh's dependency on hashbrown to 0.12.3, otherwise on-chain programs can't build.

Otherwise, this is good to go!

solana-cli-output = { version = "1.16.1", optional = true }
solana-program-test = "1.16.1"
solana-cli-output = { version = "1.16.2", optional = true }
solana-program-test = "1.16.2"
solana-rpc-client = "1.16.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah darn, we'll have to update the script to work with the new crate names. I put in #4698 to fix that up

Suggested change
solana-rpc-client = "1.16.1"
solana-rpc-client = "1.16.2"

@KirillLykov
Copy link

I think this change is relevant -- #4703
I'm not sure if sticking with particular version of hashbrown is better than adding getrandom or not. If this getrandom custom doesn't break anything, than I would argue that sooner or later we will have to upgrage hashbrown and, hence, getrandom. Maybe there is something else I'm not aware of

@samkim-crypto samkim-crypto force-pushed the upgrade-to-solana-1.16.2 branch 3 times, most recently from 41e168b to e9417f1 Compare July 7, 2023 08:34
@samkim-crypto samkim-crypto changed the title Upgrade to solana 1.16.2 Upgrade to solana 1.16.3 Jul 13, 2023
@samkim-crypto samkim-crypto merged commit 07e3ce3 into solana-labs:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants