stake-pool-cli: don't send UpdateValidatorListBalance transactions for subslices of validator list that have already been updated
#6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Nice idea! I left a few comments on CLI ergonomics. Once #6058 moves along we can circle back to this, or we can do this one first and just cherry pick the last commit and move it up, up to you!
This comment was marked as off-topic.
This comment was marked as off-topic.
billythedummy
changed the title
UpdateValidatorListBalance transactions for subslices of validator list that have already been updatedUpdateValidatorListBalance transactions for subslices of validator list that have already been updated
billythedummy
changed the title
UpdateValidatorListBalance transactions for subslices of validator list that have already been updatedUpdateValidatorListBalance transactions for subslices of validator list that have already been updated
buffalojoec
reviewed
Jan 23, 2024
buffalojoec
approved these changes
Jan 24, 2024
billythedummy
added a commit
to igneous-labs/sanctum-spl-stake-pool
that referenced
this pull request
Feb 9, 2024
…for subslices of validator list that have already been updated (solana-labs#6059) * remove unnecessary vote acc slice * nightly fmt * fix clippy * update stale validator_list_balance only if not force * merge * fmt * merge conflict * restore stale ixs, add fresh flag to update * fmt * fresh -> stale_only, update --force help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
updatecommand on thestake-pool-clialways sends update transactions for the entire validator list. This is redundant and increases the odds of failure if a previous update command failed in the middle since you don't have to run theUpdateValidatorListBalanceinstruction again on the parts of the validator list that were successfully updated. This is especially true for large stake pools - e.g. solblaze has all 2950 validators on their list.Solution
In the
updatecommand, filter outUpdateValidatorListBalanceinstructions for subslices of theValidatorListthat have already been updated. Keep the current behaviour for the--forceflag.This builds on PR #6058