-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stake redelegate #13358
Fix stake redelegate #13358
Conversation
Do you have time to take a peek at one more, @rwalker-com? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job closing a hole you can throw a cat through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take another look when you push your test changes, but fix lgtm!
It'll be good to get another winky comment in the code base as well ;)
095700c
to
95b0d83
Compare
Pull request has been modified.
Review's been addressed! |
Codecov Report
@@ Coverage Diff @@
## master #13358 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 378 378
Lines 89990 90037 +47
=======================================
+ Hits 73862 73914 +52
+ Misses 16128 16123 -5 |
This will need rebasing on #13394 (make sure it goes in stake_state.rs, as opposed to the legacy mod) |
95b0d83
to
87d661f
Compare
Rebased on #13394 |
Problem
Re-delegating a formerly delegated, but currently deactivated stake account, does not consider changes to the account balance
Summary of Changes
Use the current account balance rather than the previous delegation amount
WIP until activation is coordinated with #13357