-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite stake accounts for clear migration #13461
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13461 +/- ##
========================================
Coverage 82.2% 82.2%
========================================
Files 378 378
Lines 91258 91433 +175
========================================
+ Hits 75065 75244 +179
+ Misses 16193 16189 -4 |
62e4cc9
to
3abd834
Compare
c7f7eb2
to
397d3c5
Compare
|
@CriesofCarrots Also, I noticed that this calculation could be off without rewriting all solana/programs/stake/src/stake_state.rs Lines 902 to 906 in 3827739
|
d3593d4
to
63e87aa
Compare
a2294db
to
3766af0
Compare
3766af0
to
39fb917
Compare
f2c00ec
to
c18f84a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, this seems really close! A couple nits, and I just have a couple quick questions about the feature activation (probably I'm missing something).
cf6fc9c
to
1faaf81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the care taken on this. Lgtm!
finally! I've finished to test this locally extensively with mainnet-beta snapshot. Merging this shortly. |
* Reduce overage stake by rewritng stake accounts * Write tests and finish implemention * Create and use new feature gate * Clean up logging * Fix typo * Simplify enable_rewrite_stake * Fix typo... * Even simplify gating * Add metrics (cherry picked from commit 43d5e47)
* Reduce overage stake by rewritng stake accounts * Write tests and finish implemention * Create and use new feature gate * Clean up logging * Fix typo * Simplify enable_rewrite_stake * Fix typo... * Even simplify gating * Add metrics (cherry picked from commit 43d5e47) Co-authored-by: Ryo Onodera <ryoqun@gmail.com>
Can we remove the function |
Did you mean to necropost here? Short answer is maybe! Worth exploring |
Yes, I meant to post. Just saw the function added in this PR still being around as I am working on the feature set transition for the |
@Lichtso hmm? i think anyway, i also think it's okay to remove that function. (thanks for feature cleanup prs by the way) |
Problem
this is very much still draft.this is done job!bugs (those were fixed by #13357 and #13358) created many kinds of bad stake accounts.
Summary of Changes
todo: add test.doneFixes #