-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fragile tests in prep of stake rewrite pr #13654
Fix fragile tests in prep of stake rewrite pr #13654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13654 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 378 378
Lines 91310 91320 +10
=========================================
+ Hits 75023 75028 +5
- Misses 16287 16292 +5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the separate PR for this, and for the polish! lgtm w/ CI
Pull request has been modified.
* Fix fragile tests in prep of stake rewrite pr * Restore BOOTSTRAP_VALIDATOR_LAMPORTS where appropriate * Further clean up * Further clean up * Aligh with other call site change * Remove false warn! * fix ci! (cherry picked from commit b74d7b5)
Strictly speaking, #13461 didn't needed this. But, anyway I merged this because it's nice to have. Also, backported to v1.4 because this is test only change (very low risk) and to avoid future backport churn for inflation changes (arguably, essential). |
* Fix fragile tests in prep of stake rewrite pr * Restore BOOTSTRAP_VALIDATOR_LAMPORTS where appropriate * Further clean up * Further clean up * Aligh with other call site change * Remove false warn! * fix ci! (cherry picked from commit b74d7b5) Co-authored-by: Ryo Onodera <ryoqun@gmail.com>
Problem
Existing tests are creating bad stake accounts which are less than
rent_exempt_reserve
, notably only42
lamports... #13461 will forbid such accounts. So, fix tests first.Summary of Changes
Not ideal, but just hacky mindless replacement:
BOOTSTRAP_VALIDATOR_LAMPORTS
=>bootstrap_validator_lamports()
Fixes #