-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: correct the types of Rpc{Batch}Request
to prevent type errors in Connection.ts
#26102
Merged
steveluscher
merged 1 commit into
solana-labs:master
from
steveluscher:fix-rpc-request-types-web3
Jun 21, 2022
Merged
chore: correct the types of Rpc{Batch}Request
to prevent type errors in Connection.ts
#26102
steveluscher
merged 1 commit into
solana-labs:master
from
steveluscher:fix-rpc-request-types-web3
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2022
Codecov Report
@@ Coverage Diff @@
## master #26102 +/- ##
=======================================
Coverage 75.7% 75.7%
=======================================
Files 40 40
Lines 2348 2348
Branches 339 339
=======================================
Hits 1779 1779
Misses 450 450
Partials 119 119 |
This was referenced Aug 3, 2022
This was referenced Aug 6, 2022
This was referenced Aug 19, 2022
This was referenced Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The return value of these was incorrect, leading to an
any
propagating through the code, which led to real breakages in the framework (eg. #26099).Summary of Changes
When we properly represent this return type as a promise for an array then array methods like
map()
return correct types.