Feature - Check syscall outputs do not overlap #28599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
feature/check_syscall_outputs_do_not_overlap
branch
from
51dca6b
to
f63b329
Compare
Lichtso
force-pushed
the
feature/check_syscall_outputs_do_not_overlap
branch
from
f63b329
to
088fee1
Compare
Lichtso
force-pushed
the
feature/check_syscall_outputs_do_not_overlap
branch
from
088fee1
to
93a3f11
Compare
jstarry
approved these changes
Oct 27, 2022
Lichtso
added a commit
that referenced
this pull request
Oct 27, 2022
* Extends is_nonoverlapping() to be able to deal with two different lengths. * Uses is_nonoverlapping() for syscall output parameters. * Feature gates the new throws of SyscallError::CopyOverlapping.
Lichtso
added a commit
that referenced
this pull request
Oct 27, 2022
* Extends is_nonoverlapping() to be able to deal with two different lengths. * Uses is_nonoverlapping() for syscall output parameters. * Feature gates the new throws of SyscallError::CopyOverlapping.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
* Extends is_nonoverlapping() to be able to deal with two different lengths. * Uses is_nonoverlapping() for syscall output parameters. * Feature gates the new throws of SyscallError::CopyOverlapping. * Adds tests which trigger SyscallError::CopyOverlapping.
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
* Extends is_nonoverlapping() to be able to deal with two different lengths. * Uses is_nonoverlapping() for syscall output parameters. * Feature gates the new throws of SyscallError::CopyOverlapping. * Adds tests which trigger SyscallError::CopyOverlapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some syscalls have multiple outputs which are written back to buffers provided in the parameters. C users could accidentally provide overlapping buffers, which is kind of a foot gun.
Summary of Changes
is_nonoverlapping()to be able to deal with two different lengths.is_nonoverlapping()for syscall output parameters.SyscallError::CopyOverlapping.SyscallError::CopyOverlapping.Feature Gate Issue: #28600