API to enumerate executable program accounts in tx batch #30371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
reviewed
Feb 16, 2023
| let mut result = HashMap::new(); | ||
| lock_results.iter_mut().zip(txs).for_each(|etx| { | ||
| if let ((Ok(()), nonce), tx) = etx { | ||
| if nonce |
There was a problem hiding this comment.
As discussed, this filtering should be refactored out in a later PR as it is general step in transaction loading.
Lichtso
approved these changes
Feb 16, 2023
14 tasks
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing code that can extract unique executable program accounts from a batch of transactions.
Summary of Changes
Add a new API to accounts that returns executable program accounts from a transaction batch.
Added unit tests for the API.
Fixes #