-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SBF test that runs with stable bank and genesis to produce deterministic hash #30945
Conversation
This PR disables the assert on hash comparison. So it should not be a maintenance burden. Merging it will help prevent the test from bit rotting. |
Codecov Report
@@ Coverage Diff @@
## master #30945 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 728 727 -1
Lines 205479 205440 -39
=======================================
- Hits 167560 167550 -10
+ Misses 37919 37890 -29 |
} | ||
} | ||
|
||
#[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add #[ignore]
here?
That way it becomes more clear that this tests needs manual intervention to run and does nothing (additional, which is not already covered by other tests) by default / automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a good idea. I'll push an update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, added some comment to the start of test to indicate its purpose.
caf9ac6
to
5a53b93
Compare
Problem
No way to test if runtime is returning consistent results for various transaction use-cases after changes to the code base.
Summary of Changes
Add a new test that runs with stable bank and genesis to produce deterministic hash.
Fixes #